Wireshark-dev: Re: [Wireshark-dev] packet-rlc.c problems
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Chris Maynard <Chris.Maynard@xxxxxxxxx>
Date: Wed, 16 Nov 2011 21:31:57 +0000 (UTC)
Gisle Vanem <gvanem@...> writes:

> Ok, good. Similar problem with packet-spice.c;
>   epan/dissectors/packet-spice.c(588) : error C2371: 'POINT' : redefinition;
different basic types
>         g:\VC_2010\SDK\include\windef.h(343) : see declaration of 'POINT'.
> 
> So I suggest we rename 'POINT*' to 'SPICE_POINT*'. Attached 'svn diff
packet-spice.c'.

I prefer to use xyz_t for typedefs, so I checked in a different patch.  It also
makes it a little clearer (I think) the difference between a POINT and a
POINT16, i.e., the new names are point32_t and point16_t, respectively.  If
there's still a naming conflict somewhere after this, then I guess we can
prepend spice_ to them.

- Chris