Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 39422: /trunk/gtk/ /trunk/gtk/: main
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Fri, 14 Oct 2011 04:11:17 -0700
On Oct 14, 2011, at 4:03 AM, martinm@xxxxxxxxxxxxx wrote:

> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=39422
> 
> User: martinm
> Date: 2011/10/14 04:03 AM
> 
> Log:
> make_menu_items() isn't called without LUA support, so can't be static.

Yes, it can; the only reason it couldn't be static would be if it were called from outside gtk/main_menubar.c, which it doesn't appear to be.

Its definition might have to protected with the same #ifdef as its use(s), to avoid "defined but not used" warnings, but that's another matter.