Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 39045: /trunk/ /trunk/: tap-expert.c

[Bill Meier <wmeier@xxxxxxxxxxx>]

On 9/19/2011 1:41 PM, Bill Meier wrote:
> On 9/19/2011 9:53 AM, martinm@xxxxxxxxxxxxx wrote:
> > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=39045
> >
> > User: martinm
> > Date: 2011/09/19 06:53 AM
> >
> > Log:
> > Add expert 'Group' to output.
> >
> > Directory: /trunk/
> > Changes Path Action
> > +21 -2 tap-expert.c Modified
>
> Martin:
>
> Gives the below on Windows (which I'm not sure how to fix)
>
> tap-expert.c(59) : error C2220: warning treated as error - no 'object'
> file generated
>
> tap-expert.c(59) : warning C4273: 'expert_group_vals' : inconsistent dll
> linkage
>
> C:\Users\wmeier\Technical\Wireshark\ws\wsh-svn\epan/expert.h(48) : see
> previous definition of 'expert_group_vals'
>
> Bill

OK: Just removing the copy of expert_group_vals[] from tap-expert.c 
seems to fix the problem. I've committed this change.

Bill