Wireshark · Wireshark-dev: Re: [Wireshark-dev] Brutal patch to build with GTK 3.0

[Anders Broman <anders.broman@xxxxxxxxxxxx>]

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Balint Reczey
Sent: den 19 augusti 2011 10:45
To: wireshark-dev@xxxxxxxxxxxxx
Subject: Re: [Wireshark-dev] Brutal patch to build with GTK 3.0

On 08/19/2011 02:01 AM, Stephen Fisher wrote:
>>
>> On Thu, Aug 18, 2011 at 05:55:43PM -0600, Stephen Fisher wrote:
>>> On Thu, Aug 18, 2011 at 06:31:56PM +0200, Anders Broman wrote:
>>>
>>>> I don't mind if some one commits the patch, but I think you have to 
>>>> build with the new UI MANAGER on GTK 3.0 as there is quite a bit of 
>>>> "factory" stuff left to fix.  Unless we want to break the remaining 
>>>> statistics functions until fixed. My GTK 3.0 box is at work so I 
>>>> can't try GTK 3.0 builds until tomorrow.
>>>
>>> I committed it as r38612 since it doesn't seem to cause problems when 
>>> compiling with GTK 2.  The new UI manager code is enabled by default 
>>> when building with GTK 3 now.
>>
>> ... on second thought, it isn't all contained within #if statements 
>> for GTK 3 builds only, so it could affect GTK 2 builds as well.  I 
>> backed it out as of r38613.
>Could we please commit it after changing //-s to #ifdef-s?
>
>Cheers,
>Balint

Should all be done in r38615...
Anders 
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe