Wireshark-dev: Re: [Wireshark-dev] localtime_r() in gtk/timeshift_dlg.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Edwin Groothuis <wireshark@xxxxxxxxxxx>
Date: Tue, 16 Aug 2011 22:37:07 +0000 (UTC)
Gisle Vanem <gisle.vanem@...> writes:

> 
> This:
>   #ifdef _MSC_VER
>   #define localtime_r(a, b) memcpy((b), localtime((a)), sizeof(struct tm));
>   #endif
> 
> doesn't look so safe. We should maybe use the localtime_r() in
> wsutil/strptime.c?

It is time to make localtime_r in wsutil/strptime.c non-static and prototype it
in wsutil/strptime.h!

Edwin