Wireshark-dev: Re: [Wireshark-dev] Please review: GSEAL fixes: allocation
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Wed, 27 Jul 2011 23:09:23 +0200
On Wed, Jul 27, 2011 at 12:29:17PM -0600, Stephen Fisher wrote:
> Sure, did you already commit it?  I did quite a bit of -DGSEAL cleanup 
> not too long ago.

Yes, I did:

------------------------------------------------------------------------
r38215 | jmayer | 2011-07-26 21:01:01 +0200 (Di, 26 Jul 2011) | 6 lines

Replace access to ...->allocation by gtk_widget_get_allocation +
  using the return val - part 1
Maybe the call needs to be done more often.

Replace GTK_WIDGET_STATE by gtk_widget_get_state

------------------------------------------------------------------------
r38216 | jmayer | 2011-07-26 21:24:19 +0200 (Di, 26 Jul 2011) | 2 lines

Remove some more GTK_WIDGET_STATE

------------------------------------------------------------------------
r38217 | jmayer | 2011-07-26 21:44:06 +0200 (Di, 26 Jul 2011) | 2 lines

Part 2 of the cleanup. fix some compile errors in previous patch.

------------------------------------------------------------------------

I just hope it works - so if you know what to test, please do so.

Ciao
  Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.