Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 37826: /trunk/epan/dissectors/ /trun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Date: Tue, 26 Jul 2011 14:18:25 -0400
Guy Harris wrote:

On Jun 29, 2011, at 12:04 AM, Stig Bjørlykke wrote:


I have strengthened the heuristics in revision 37828, which seems to
really fix the problem.


Well, it fixes the problem with that *particular* capture.
The underlying problem is that proto_tree_add_item() might not end up doing anything that checks the validity of the offset, 

Is that because of:

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3290
? Shouldn't we fix that? (I need to look at that again; last time I did I was not comfortable with it--the claim, the fix...)