Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

["Maynard, Chris" <Christopher.Maynard@xxxxxxxxx>]

> -----Original Message-----
> From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-
> bounces@xxxxxxxxxxxxx] On Behalf Of Steve Karg
> Sent: Tuesday, July 19, 2011 9:06 AM
> To: Developer support list for Wireshark
> Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 38106:
> /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c
> 
> I have access to the BACnet standard, and need to update the dissector
> to expand some enumerations and value strings soon (the standard keeps
> expanding, for some reason). Most likely the conversions are Big
> Endian as most encodings in BACnet are network byte order, and most
> likely the cause of TRUE in the fields is from copy-paste (I'm sure
> I'm guilty of that).  I'll review the changes and submit a patch if it
> is needed.  Is there any other cleanup in the BACnet dissector that
> needs attention?

Thanks Steve.  I changed all the ENC_LITTLE_ENDIAN's to ENC_BIG_ENDIAN's in r38110.  I'm not aware of any other changes that are needed ... but I don't know anything about this protocol and haven't looked at it beyond what was needed to fix bug 5769.

- Chris

CONFIDENTIALITY NOTICE: The contents of this email are confidential
and for the exclusive use of the intended recipient. If you receive this
email in error, please delete it from your system immediately and 
notify us either by email, telephone or fax. You should not copy,
forward, or otherwise disclose the content of the email.