Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 38028: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

["Maynard, Chris" <Christopher.Maynard@xxxxxxxxx>]

> -----Original Message-----
> From: wireshark-commits-bounces@xxxxxxxxxxxxx [mailto:wireshark-commits-
> bounces@xxxxxxxxxxxxx] On Behalf Of sake@xxxxxxxxxxxxx
> Sent: Thursday, July 14, 2011 5:27 PM
> To: wireshark-commits@xxxxxxxxxxxxx
> Subject: [Wireshark-commits] rev 38028: /trunk/epan/dissectors/
> /trunk/epan/dissectors/: packet-icmp.c
> 
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=38028
> 
> User: sake
> Date: 2011/07/14 02:27 PM
> 
> Log:
>  If the first 8 bytes of the icmp echo/echo-reply data look like a
> timestamp, dissect it as a timestmap and calculate the time since the icmp
> packet was created.
> 
> Directory: /trunk/epan/dissectors/
>   Changes    Path             Action
>   +50 -21    packet-icmp.c    Modified

Sake, now that you've dug into timestamps for ICMP echo/echo-reply data, maybe you might have some thoughts about how to improve the last patch I submitted to bug 5770 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5770)?  I'm sure the patch will no longer apply cleanly now, but hopefully you can get a feel for what I was trying to do.  If you really want, I can resubmit a patch that will apply cleanly to the trunk.

- Chris



CONFIDENTIALITY NOTICE: The contents of this email are confidential
and for the exclusive use of the intended recipient. If you receive this
email in error, please delete it from your system immediately and 
notify us either by email, telephone or fax. You should not copy,
forward, or otherwise disclose the content of the email.