Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/

[Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>]

On Fri, Apr 22, 2011 at 5:18 PM, Jeff Morriss <jeff.morriss.ws@gmail.com> wrote:

Stephen Fisher wrote:

On Fri, Apr 22, 2011 at 03:09:01PM +0200, Alexis La Goutte wrote:

Why not add a check (in checkAPIs.pl) if proto_item_add_subtree always return a value ?

Good idea.  Another way to do it is a gcc attribute called warn_unused_result:
 http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html

That was my thought this morning as well; I added that check (after fixing all the resulting warnings) in rev 36812.

Great :)