Wireshark-dev: Re: [Wireshark-dev] Enhancement-Request: RTP-MIDI dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Dirk Jagdmann <doj@xxxxxxxxx>
Date: Thu, 09 Dec 2010 08:47:19 -0800
Tobias Erichsen wrote:
> Hi everyone,is there anyone who can give me some feedback on the time it will take,until someone takes a look at my enhancement request:https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5451Thanks a lot...Best regards,Tobias

So far I have only looked at your code and it looks fine. However there are some
other MIDI over network (on different layers) protocols out there. Since you
have made such a nice general MIDI dissector, how about factoring out that into
a separate "module", which can be called from other/future dissectors, so that
we don't need to have a new MIDI dissection implementation for other protocols.

-- 
---> Dirk Jagdmann
----> http://cubic.org/~doj
-----> http://llg.cubic.org