Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 34860: /trunk/gtk/ /trunk/gtk/: text_import.c

[Anders Broman <anders.broman@xxxxxxxxxxxx>]

Hi,

I think the answer to the problem is that the flex generated files needs to be compiled without the  -Werror flag. 

 

Compare with Makefile.am in epan

if HAVE_WARNINGS_AS_ERRORS

AM_NON_GENERATED_CFLAGS = -Werror

endif

:

libwireshark_la_SOURCES = \

$(LIBWIRESHARK_SRC) \

$(LIBWIRESHARK_INCLUDES)

libwireshark_la_CFLAGS = $(AM_NON_GENERATED_CFLAGS) $(py_dissectors_dir)

libwireshark_generated_la_SOURCES = \

$(LIBWIRESHARK_GENERATED_SRC) \

$(LIBWIRESHARK_GENERATED_INCLUDES)

Best regards

Anders

---

From: Anders Broman
Sent: den 15 november 2010 14:45
To: 'Developer support list for Wireshark'
Subject: RE: [Wireshark-dev] [Wireshark-commits] rev 34860: /trunk/gtk/ /trunk/gtk/: text_import.c

Hi,

Weird, it works on an old etch here with flex 2.5.33...gcc 4.1.2 20061115(prerelease)

/Anders

---

From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Pascal Quantin
Sent: den 15 november 2010 14:18
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 34860: /trunk/gtk/ /trunk/gtk/: text_import.c

Hi

2010/11/15 Jaap Keuter <jaap.keuter@xxxxxxxxx>

Hi,

I hear you. I'm already taking that step back, first of all splitting text_import.h and working without this access function so gracefully provided by newer flex versions.

On that matter, AFAIK your version should provide this function. Can you have a look at text2pcap.c for instance? That should have the function yyset_in().

It looks like I forgot to clean my objects after upgrading flex... Sorry for the false alarm.Now I have the following error when compiling svn revision 34872:

gcc -DHAVE_CONFIG_H -I. -I..  -I.. -I../wiretap    -I/usr/local/include -I /home/pascal/soft/include  '-DPLUGIN_DIR="/usr/local/lib/wireshark/plugins/1.5.0"' -Werror -DINET6 -D_U_="__attribute__((unused))" -g -O2 -Wall -W -Wextra -Wdeclaration-after-statement -Wendif-labels -Wpointer-arith -Wno-pointer-sign -Warray-bounds -Wcast-align -Wformat-security -I/usr/local/include -D_REENTRANT -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/pixman-1   -I /home/pascal/soft/include  -MT text_import_scanner.o -MD -MP -MF .deps/text_import_scanner.Tpo -c -o text_import_scanner.o text_import_scanner.c
cc1: warnings being treated as errors
text_import_scanner.c: In function 'yy_get_next_buffer':
text_import_scanner.c:1121: error: comparison between signed and unsigned
make[2]: *** [text_import_scanner.o] Error 1

My test2pcap.c file does not contain any yyset_in() function.

BTW, I have no issue when using a Unbuntu 10.10 or Windows. Only with my Debian...

Regards,
Pascal.