Wireshark-dev: Re: [Wireshark-dev] TCP data PDU decoding fails depending on TCP options field?
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Fulko Hew <fulko.hew@xxxxxxxxx>
Date: Fri, 1 Oct 2010 15:54:45 -0400


On Fri, Oct 1, 2010 at 3:19 PM, Sake Blok <sake@xxxxxxxxxx> wrote:
On 1 okt 2010, at 20:35, Fulko Hew wrote:

> On Fri, Oct 1, 2010 at 2:18 PM, Sake Blok <sake@xxxxxxxxxx> wrote:
> Could you please open a bug report at http://bugs.wireshark.org and attach the two tracefiles so that we don't lose track of it?
>
> Done, bugzilla entry #5269 submitted.
>
>  https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5269

Thanks, this will prevent it from being forgotten.

I just checked in a partial fix. Now the packets in your trace are indeed decoded, however, there are still some problems with the dissection, so I will leave the bug open until that is fixed too.

I looked at the src for that dissector, and I found that the enumerations for the bit mask for the flags field
were all 'off-by-one' and that the endian-ess macro was there and used in numerous places.

By shifting the mask enumerations, I got the dissector to work, but I didn't check the details.

Fulko