Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 32522: /trunk/gtk/ /trunk/gtk/: main_proto_draw.c

[Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx>]

Hi,

On Tue, Apr 20, 2010 at 10:22:11AM +0200, Stig Bj?rlykke wrote:
> On Tue, Apr 20, 2010 at 9:47 AM,  <etxrab@xxxxxxxxxxxxx> wrote:
> >  From Jakub Zawadzki:
> >  Improve bitview display
> 
> This patch introduces the bugs listed in comment 1 in the bug report.
> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413#c1

>> - Selecting bits in the bit view does not always select the correct tree
>>   entry. (both integer and boolean values)

I can reporduce this bug without patch.

>> - I don't think we should highlight parts of a byte in hex view.

It's fixed in new version.

>> - We should fix the LE vs BE for multi byte entries before adding such a patch.

(Temporary) Disabled for len > 1...

>> I'm a bit concerned that we will get a lot of dissector "bugs", like
>> the ip.flags and ip.version.

It's should be fixed by dissectors maintainers anyway.
It might be easier to fix it with this patch commited.

Cheers.