Wireshark · Wireshark-dev: Re: [Wireshark-dev] preliminary code submission

[Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx>]

Hi,

On Wed, Feb 03, 2010 at 11:44:40AM -0500, Brian Oleksa wrote:
> Again... any feedback is appreciated.

- Inconsistent indentation (you use sometimes \t sometimes spaces)
- C++ comments style.
- using value_string struct is more proper way to map value with string than switch-es...

- You have lot of unused variables, like: 
> gfloat latitude;
> latitude = tvb_get_ntohieee_float(tvb,offset);
or
> struct e_in6_addr address;
> tvb_get_ipv6(tvb, offset, &address);

- duplicated mon_names[]

- check_col() is not needed.
- data_handle is never used.

Cheers.