Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 31774: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 31774: /trunk/epan/dissectors/ /trun

From: Stig Bjørlykke <stig@xxxxxxxxxxxxx>

Date: Wed, 3 Feb 2010 09:45:42 +0100

On Wed, Feb 3, 2010 at 12:33 AM, Guy Harris <guy@xxxxxxxxxxxx> wrote:
> NDS's "Reassembled length" field is in generated code; the generator is tools/ncp2222.py.  I've updated that.

We have some other dissectors with just "Reassembled length", the plan
was to match this with the name of the data source.

> Should the field names be "{proto}.reassembled.length", or "{proto}.reassembled_length"?  Do we expect to have other fields with information associated with the reassembly?

We also have "{proto}.reassembled.in" vs. "{proto}.reassembled_in", I
just used the same syntax as in each dissectors for the length.
I'll change to "reassembled.length".

-- 
Stig Bjørlykke

Follow-Ups:
- Re: [Wireshark-dev] [Wireshark-commits] rev 31774: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-clnp.c packet-p_mul.c packet-tcp.c packet-x25.c
  - From: didier

References:
- Re: [Wireshark-dev] [Wireshark-commits] rev 31774: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-clnp.c packet-p_mul.c packet-tcp.c packet-x25.c
  - From: Guy Harris

Prev by Date: [Wireshark-dev] buildbot failure in Wireshark (development) on Ubuntu-9.10-x64
Next by Date: [Wireshark-dev] Capture filter syntax check - why no check before starting a session?
Previous by thread: Re: [Wireshark-dev] [Wireshark-commits] rev 31774: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-clnp.c packet-p_mul.c packet-tcp.c packet-x25.c
Next by thread: Re: [Wireshark-dev] [Wireshark-commits] rev 31774: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-clnp.c packet-p_mul.c packet-tcp.c packet-x25.c
Index(es):
- Date
- Thread