Wireshark-dev: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 4339] [PATCH] VNC dissector cleanups a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Bill Meier <wmeier@xxxxxxxxxxx>
Date: Sun, 10 Jan 2010 08:44:53 -0500
bugzilla-daemon@xxxxxxxxxxxxx wrote:

I'm not sure what the consequence of the removal of the 2nd
'heur_dissector_add("tcp", test_vnc_protocol, proto_vnc);' line.

I've added it in rev. 28394, can't see the logic why it was added twice (and
why not remove the first call to it).
If I understand your question correctly: heur_dissector_add needs to be called only once (ie the first time reg_handoff_vnc is called).