Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 29427: /trunk/ /trunk/epan/dissectors/: packet-bthci_acl

[Jaap Keuter <jaap.keuter@xxxxxxxxx>]

Hi,

Yes, because these are real bugs.

Thanx,
Jaap

Send from my iPhone

On 27 sep 2009, at 21:50, didier <dgautheron@xxxxxxxx> wrote:

> Hi,
> Le vendredi 25 septembre 2009 à 14:30 -0700, Guy Harris a écrit :
> > On Aug 14, 2009, at 11:38 PM, krj@xxxxxxxxxxxxx wrote:
> >
> > > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=29427
> > >
> > > User: krj
> > > Date: 2009/08/14 11:38 PM
> > >
> > > Log:
> > > This patch introduces packet_add_new_data_source() which effectively
> > > deprecates add_new_data_source(). This is based on the following
> > > observation:
> > >
> > > 1) The tvb + name (aka. data_source) is only used when the protocol
> > > tree is visible
> >
> > Nope.  It's also used, for example, by "tshark -x", even if "-V"  
> > isn't
> > specified.  There may be other places where it's used as well.
> Hum, does it means that all dissectors using
> if (tree) {...; call_dissector(data_handle,...) }
>
> Have to be modified?
> Didier
>
>
>
> ___________________________________________________________________________


> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe