Wireshark · Wireshark-dev: Re: [Wireshark-dev] [PATCH] new dissector for ip.access GSM A-bis over IP

[Harald Welte <laforge@xxxxxxxxxxxx>]

Hi Michael,

good to hear from you!

On Sat, Jul 04, 2009 at 10:51:31AM +0200, Michael Tüxen wrote:
 
> I get a warning that len might be used uninitialized in  
> dissect_ipa_attr, which is the case if attr_type is neither 0x00 nor 0x01.
> What is the  right action if the switch statement falls through?

Thanks.  Interestingly, my compiler version did not complain about it.

In any case, the right action would be to simply print something like
'unknown type' and skip to the next tag, based on the length that we
have determined.

> Why do you need the tag variable in that function?

I don't ;)

I'll fix those two issues and re-submit (this time to the bugtracker) as soon
as I find a minute for it.
 
Regards,
-- 
- Harald Welte <laforge@xxxxxxxxxxxx>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)