Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 3138] New: Buildbot crash output: fuzz-2008-12-18-2313.pca

[Gerald Combs <gerald@xxxxxxxxxxxxx>]

Martin Mathieson wrote:
> I wanted to add a field that took its value from the a range of bytes in
> the tvb, but I wanted control over what the label looked like (and I
> didn't want to the the truncated sequence of bytes in the item).  I
> couldn't see anyway to do this, other than doing proto_tree_add_item()
> followed by proto_item_set_text().  Am I missing something obvious here?
> 
> Looking at Gerald's change 27053, there were lots of functions that
> wanted to do the same thing as I wanted, but they had to call
> tvb_get_ptr() just to get the data the match the selected range of bytes.
> 
> Once again, I apologise for my rash change - but I think there's the
> need for a function that does what I changed
> proto_tree_add_bytes_format() to do.
> 
> What should we do now?

Could we modify proto_tree_add_bytes_format to use the bytes from the tvb if
start_ptr is NULL?

I've backed out revisions 27047 and 27053 in the meantime.

-- 
Join us for Sharkfest’09  |  Stanford University, June 15 – 18
http://www.cacetech.com/sharkfest.09/

EARLY REGISTRATION DISCOUNTS through JANUARY 31, 2009