Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 26377: /trunk/epan/dissectors//trun
Hi,
A clear comment line explaining the hack may help here...
Thanx,
Jaap
Greg Morris wrote:
Stig,
Well that white space was there on purpose...
{ 15, "Read Class Definition " },
It is there because the packet-ncp2222.inc when it processes the NDS
verb echos the string value to the summary window. Then as part of the
same dissection process it echos the value of the name of the entry ID
that is included in the packet to the summary window. Note the packet
doesn't hold this value but it a memory table to allow the dissector to
lookup the EID (entry ID included in the packet) and find the associated
name. This name is then echoed to the summary window as well.
With the white space the summary window would be something like.
C Read Class Definition -> Object user1.novell
Without the white space the summary window would be something like.
C Read Class Definition-> Object user1.novell
I added this on purpose to make the summary window consistent with the
display of the other NDS verbs. I know this is a hack but someone has
done white space cleanup in the past on this and I have had to go back
and change several times. I am sure that some of the other white space
cleanup has caused some of the other verbs to display the summary in a
similar manner but I just haven't ran across a packet trace that shows
it.. I try to cleanup and fix these when I find them.
Greg
>>> On 10/8/2008 at 2:30 PM, in message
<20081008123023.DC822234EE@xxxxxxxxxxxxxxxxxx>, <stig@xxxxxxxxxxxxx> wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=26377
<http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=26377>
User: stig
Date: 2008/10/08 05:30 AM
Log:
Remove a space, which I think was accidentally added in r26012.
Directory: /trunk/epan/dissectors/
Changes Path Action
+1 -1 ncp2222.py Modified
