Wireshark-dev: Re: [Wireshark-dev] Return -1 from a heuristic dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: "Martin Mathieson" <martin.r.mathieson@xxxxxxxxxxxxxx>
Date: Wed, 11 Jun 2008 21:08:39 +0100

On Wed, Jun 11, 2008 at 8:59 PM, Stig Bjørlykke <stig.bjorlykke@xxxxxxxxx> wrote:
On 11. juni. 2008, at 16.22, Martin Mathieson wrote:

> Section 2.7.2 of README.developer suggests that it should return 0,
> since that's how many bytes it has dissected.
>
> It also shouldn't be setting desegment_len to 1.  It should either
> set it to DESEGMENT_ONE_MORE_SEGMENT, or (better, where known) the
> actual number of bytes its waiting for.

Ok.  I have no ms-mms packets to test with, but the changes seems
reasonable so I will go for this.


If you make the change(s) I'll try to sync to it and dig out a capture file I have later.