Wireshark-dev: Re: [Wireshark-dev] SSL decryption breaks after retransmission
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Sake Blok <sake@xxxxxxxxxx>
Date: Thu, 29 May 2008 19:26:13 +0200
On Thu, May 29, 2008 at 12:26:09PM -0400, Jeff Morriss wrote:
> Sake Blok wrote:
> > Any objections to the following fix:
> > 
> > Have a preference in the tcp profile like "show retransmitted frames
> > as data" with tooltip "Dissecting the same fragment of data twice 
> > can disrupt the upper layer dissectors (ssl-decryption for example)".
> > By default this preference will be unchecked to not change the current 
> > behavior.
> 
> How about something more like "Don't pass retransmitted fragments..." to 
> make it clearer the effect of setting the option?

Now that I read my suggestion back, I think you're right that it might
not be the "clearest of descriptions", I will give the exact description
some more thought :-)

> (BTW I would think it should actually be defaulted to on.)

In that case, should it be a preference at all? Or should it just become
the way things are?

Cheers,
    Sake