Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 25362: /trunk/wsutil/ /trunk/wsutil/
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Sat, 24 May 2008 22:15:05 +0200
On Fri, May 23, 2008 at 02:15:28AM +0000, guy@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=25362
> 
> User: guy
> Date: 2008/05/22 07:15 PM
> 
> Log:
>  file_util.c is only for Windows; don't build it on UN*X.  Put in a check
>  to cause it to fail when built on UN*X, and get rid of code that's not
>  needed on Windows.
> 
> Directory: /trunk/wsutil/
>   Changes    Path               Action
>   +4 -2      Makefile.am        Modified
>   +0 -2      Makefile.common    Modified
>   +1 -1      Makefile.nmake     Modified
>   +4 -37     file_util.c        Modified

Wouldn't it have been easier to just protect the files by #ifdef win32 #endif?
We already have a few files that are protected that way.

 Ciao
      Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.