Wireshark · Wireshark-dev: [Wireshark-dev] Problem (and fix?) building pdfs from docbook

[Joerg Mayer <jmayer@xxxxxxxxx>]

I'm running opensuse-factory with fop-0.94.
When trying to build the documentation, it failed. After making the follwing
change I could build the docs again:

Index: custom_layer_pdf.xsl
===================================================================
--- custom_layer_pdf.xsl        (revision 25305)
+++ custom_layer_pdf.xsl        (working copy)
@@ -9,7 +9,9 @@

 <!-- create pdf bookmarks -->
 <!-- Disable this since FOP 0.93 doesn't handle them, yet -->
+<!--
 <xsl:param name="fop.extensions" select="1"/>
+-->

 <!-- don't use the draft mode (no loading of image from the web) -->
 <xsl:param name="draft.mode" select="no"/>

Can anyone who actually understands a bit about docbook let me know whether
this fix is correct or will break things for others?

Thanks
      Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.