Wireshark-dev: Re: [Wireshark-dev] Result of CheckAPI in Wiretap dir
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 07 May 2008 11:50:17 -0700
Stephen Fisher wrote:
I believe g_strup/_strdown should be replaced by g_ascii_strup/_strdown, but I'm not positive.
Yes, unless it's perfectly OK for "i" to be mapped to "İ", and for "I" to be mapped to "ı", if the user is in a Turkish locale, for example. 

Yes, that really *did* break something:

	http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2010
I.e., if you expect case-mapping to do the "obvious" mapping, for "obvious" as defined by English speakers (or perhaps speakers of other Western European languages), or even if you just expect it to do the *same* mapping in all locales, don't use g_strup() or g_strdown(), use the ASCII-only variants of them.