Wireshark · Wireshark-dev: [Wireshark-dev] test code (test/suite_capture.sh) uses icmp capture filter "all the time"?

[Ulf Lamping <ulf.lamping@xxxxxx>]

Hi!

Just stumbled across the filter string "icmp" in test/suite_capture.sh 
(several places):

   $DUT -i $TRAFFIC_CAPTURE_IFACE $TRAFFIC_CAPTURE_PROMISC \
       -w ./testout.pcap \
       -c 10  \
       -a duration:$TRAFFIC_CAPTURE_DURATION \
       -f icmp \
       >> ./testout.txt 2>&1


I just don't understand the line "-f icmp", is there a reason for it or 
is this some kind of copy/paste error?


I mean e.g. the first test "capture_step_10packets" should simply test 
if it can capture 10 packets and should *not* test the filtering system. 
For example if there's a bug in the filtering system, this test would 
fail although plain capturing maybe works ok.

Regards, ULFL