Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 24640: /trunk/ /trunk/packaging/macosx/ChmodBPF/: ChmodB

[Gerald Combs <gerald@xxxxxxxxxxxxx>]

Stig Bjørlykke wrote:
> I had a look at the OSX packaging and found some errors while trying to
> build a dmg:
> 
> * osx-build.sh is calling osx-app.sh with argument "-b" instead of
> "-bp", which fails.  The attached patch fixes this.
> 
> * osx-dmg.sh creates "Wireshark 1.0.0 Intel.dmg" while osx-build.sh
> tries to rename "Wireshark.dmg" to "Wireshark-24687-10.5-i386.dmg",
> which fails.

osx-build.sh is definitely broken. I've been using the 'osx-package' target in
the top-level Makefile, which calls osx-app.sh and osx-dmg.sh, to create packages.

> * Wireshark.app/Contents/MacOS/Wireshark is missing without any notice
> (I haven't figured out why), which causes the application to fail on
> startup.

This should be done by osx-app.sh (line 203).

> The announced 1.0.0pre1 dmg works correctly.  The Wireshark icon is a
> bit bigger than other icons when -TAB, which doesn't look "as it should
> be".

It looks like the 128-pixel versions other application icons have empty space
and/or drop shadows around them. I'll do the same with the Wireshark icon.