Looks good.
BTW: I tested "eth.src" as a custom column, but it does not sort correctly. I know there's a column preference for it already, which does sort correctly though, so maybe it's no big deal?
One more thing, after alphabetizing the column choices in the last patch I submitted, it seems to me that there are quite a few redundancies. For example:
1) Hardware src addr <=> Hw src addr (resolved)
2) Hardware dest addr <=> Hw dest addr (resolved)
3) Source port <=> Src port (resolved)
4) Destination port <=> Dest port (resolved)
5) Source address <=> Src addr (resolved) <=> Network src addr <=> Net src addr (resolved)
6) Destination address <=> Dest addr (resolved) <=> Network dest addr <=> Net dest addr (resolved)
7) Src addr (unresolved) <=> Net src addr (unresolved)
8) Dest addr (unresolved) <=> Net dest addr (unresolved)
Are all of those really necessary? My suggestion would be to eliminate all the redundant column choices to help clean up the list. Doing so would reduce the column list by at least 12 items from the above list. I think keeping the "(resolved)" versions makes things clearer. For example, eliminate "Destination port" and keep "Dest port (resolved)", as "Destination port" is ambiguous as to whether the port is resolved or not.
- Chris
-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Stig Bjørlykke
Sent: Saturday, February 23, 2008 5:15 AM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] New feature: custom columns
2008/2/23, Maynard, Chris <Christopher.Maynard@xxxxxxxxx>:
> BTW: I added a new column, "Proto2" of type "Protocol", so that there were now 2 of them. After hitting "OK", then going back into "Edit -> Preferences -> Columns", I saw this: "Proto2 Protocol ()". Note the empty parenthesis.
Yup, fixed in revision 24442.
Thank you for testing and reporting bugs!
--
Stig Bjørlykke
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev
-----------------------------------------
This email may contain confidential and privileged material for the
sole use of the intended recipient(s). Any review, use, retention,
distribution or disclosure by others is strictly prohibited. If you
are not the intended recipient (or authorized to receive for the
recipient), please contact the sender by reply email and delete all
copies of this message. Also, email is susceptible to data
corruption, interception, tampering, unauthorized amendment and
viruses. We only send and receive emails on the basis that we are
not liable for any such corruption, interception, tampering,
amendment or viruses or any consequence thereof.
