Wireshark · Wireshark-dev: Re: [Wireshark-dev] Request for review: bug #2048

[Alexey Neyman <avn@xxxxxxxxxxxxxxx>]

Hi Richard,

Started separation of changes; first part of the changes (BASE_CUSTOM) 
is available for review in the bug #2191.

Best regards,
Alexey.

On 13 January 2008 Richard van der Hoff wrote:
> Hi Alexey,
>
> Alexey Neyman wrote:
> > Actually, there is one more addition to epan/proto.c:
> > proto_tree_add_bitmask_text(), more flexible version of
> > proto_tree_add_bitmask().
> >
> > Would it help if I separate these enhancements to common
> > code from the dissector enhancements and submit them
> > separately?
>
> It would definitely help if you could break the patch up into smaller
> components. I'd suggest that you file a few separate bugs concerning
> various bits of new functionality.
>
> Sorry to make more work for you but it's difficult for us to get
> around to reviewing patches, and as Jaap notes a patch that requires
> careful consideration is likely to get back-burnered...
>
> Thanks
>
> Richard
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev