Wireshark-dev: Re: [Wireshark-dev] [Patch] Visual and PPP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 21 Nov 2007 14:10:34 -0800
James Menzies wrote:
It would be greatly appreciated it if the following minor patch could be applied. This corrects two long standing issues with the Visual Networks file type in PPP and ML-PPP environments. 

And causes bug 2005:

	http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2005

so I'll back the change out.
The problem is that you cannot rely on PPP frames beginning with 0xff 0x03, as Address-and-Control-Field-Compression might have been turned on (and *is* negotiated on in the capture in bug 2005). Another scheme is required to distinguish PPP frames from Cisco HDLC frames.
Do you have any examples of capture files that aren't handled correctly by the old code, so we can try to figure out code that handles both those files and the files attached to bug 2005?