Wireshark-dev: Re: [Wireshark-dev] Wish: Mark/Find the element matching the display filter
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Stephen Fisher <stephentfisher@xxxxxxxxx>
Date: Tue, 20 Nov 2007 15:42:46 -0700
On Tue, Nov 20, 2007 at 09:44:52AM -0800, Andrew Feren wrote:

> > On Mon, Nov 19, 2007 at 02:43:13PM -0700, Stephen Fisher wrote:
> > 
> > My bad, it does work as I had intended.  It highlights the field (with
> > the function highlight_field()) whenever you do a hex or string search,
> > but not when you do a filter search.  Should we add filter search
> > matches too?
> 
> Yes, please!
> 
> I'm willing to help if someone can point me in the right direction.  I
> frequently work with several protocols that would benefit from this
> functionality.

Take a look at my SVN commit #19897, which introduced this feature:

  http://anonsvn.wireshark.org/viewvc/viewvc.py?view=rev&revision=19897

The "infrastructure" is there to highlight fields, it just needs to be
extended to include filter matches.  I'm not sure how much work that
will take without looking at it further.


Steve