Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 23128:/trunk/asn1/h225/ /trunk/asn1/
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: "Kukosa, Tomas" <tomas.kukosa@xxxxxxxxxxx>
Date: Wed, 10 Oct 2007 11:30:46 +0200
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=23128
> > 
> > Log:
> >  solution for different submake calling on Windows and Linux
> >  only one dissector is committed to test it
> > 
> > Directory: /trunk/asn1/h225/
> >   Changes    Path               Action
> >   +2 -0      Makefile.am        Modified
> >   +2 -2      Makefile.common    Modified
> >   +1 -0      Makefile.nmake     Modified
> 
> Thanks! Is there a reason why you modified M.am and M.nmake instead of
> M.inc and M.inc.nmake in asn1/ ? That way I'll only need to change the
> M.common files.

The reason is that MAKE_CNF_EXPORT has to be defined before M.common is
included.
It is why I suggest to think about M.preinc and M.preinc.nmake
introducing an put MAKE_CNF_EXPORT into them.
and change <proto>/M.am to
include ../Makefile.preinc
include Makefile.common
include ../Makefile.inc
and change <proto>/M.namake to
include ../../config.nmake
include ../Makefile.preinc.nmake
include Makefile.common
include ../Makefile.inc.nmake

What do you think about this solution?