Hello,
I am still waiting for feedback on my submit request. May be the better and proper way is including it in CVN repository?
Thank you,
Valery.
-----Original Message-----
From: Valery Sigalov
Sent: Wednesday, September 12, 2007 1:52 PM
To: 'Developer support list for Wireshark'
Subject: RE: [Wireshark-dev] New dissector for TPNCP protocol
Hi,
The first version of TPNCP plugin was developed for Ethereal 0.9.7 in October 2002. Since then it was widely used by our QA, Support, FAE and lot of our clients. It also passed very intensive QA tests during this period.
The plugin was distributed as a part of Audiocodes' SW Release Package as shared object for Windows, Linux and UNIX platforms and tpncp.dat file. We planned to submit the "static" dissector code and continue to distribute the automatically generated tpncp.dat file as a part of the package. The package released approximately once in half a year.
There is absolutely no problem to release tpncp.dat file separately under GNU GPL license or even as a part of Wireshark distribution, since there is no connection between this file and Audiocodes' SW after its generation. The problem is that Audiocodes and Wireshark releases are not synchronized.
Without tpncp.dat file the dissector even does not registered, so it can not affect the quality of Wireshark project. We can also perform very intensive QA tests during development cycle and before release. Anyway, if you see the better solution of this problem, I will be glad to implement it.
The location of tpncp.dat file has historical reasons when it was distributed as a part of TPNCP plugin and it was convenient having them in the same directory. I just did not find the better place, but it can be easily changed.
Thank you,
Valery.
-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Jaap Keuter
Sent: Wednesday, September 12, 2007 12:09 AM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] New dissector for TPNCP protocol
Hi,
I've a few questions on this. First of all what's the status of this
external tpncp.dat file? Under what license is it distributed?
I'm not sure if I like the idea of such a 'flexible' dissector since we
never can be sure of the quality of the dissector since it depends on
the tpncp.dat file being loaded, and that is 'out of our control'.
I also don't like the location in the plugin directory for that matter,
but that is just an implementation detail.
just my E0.02.
Jaap
Valery Sigalov wrote:
> Hello,
>
> I attached the new protocol dissector source code (packet-tpncp.c).
>
> The 'Makefile.common' from 'epan/dissectors' directory was changed like
> following: the name of the new source file was added to 'DISSECTOR_SRC'
> macro.
>
> The new Wiki page on the protocol was created
> (http://wiki.wireshark.org/TPNCP).
>
> The example of tpncp.dat file needed for proper work of TPNCP dissector
> attached to protocol Wiki page. This file *should not* be the part of
> the project and distributed separately with AudioCodes' SW Release
> Package.
>
> The sample captures (tpncp_udp.pcap and tpncp_tcp.pcap) were added to
> the SampleCaptures page.
>
> The fuzz testing passed OK.
>
> The following platforms were tested - Windows 2000/XP/2003/Vista, Linux
> RHEL/Fedora/Suse/Debian, Sun Solaris 9 and 10 (Intel and Sparc).
>
>
>
> Please review the attached sources if they are ok and add them to
> repository. Please give me the feedback if I need to change something.
>
>
>
> Thank you,
>
> Valery.
>
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev
