Wireshark · Wireshark-dev: Re: [Wireshark-dev] Capture->Interface shows incorrect statistics

["Fulko Hew" <fulko.hew@xxxxxxxxx>]

On 8/30/07, Stig Bjørlykke <stig.bjorlykke@xxxxxxxxx> wrote:

Den 30. aug. 2007 kl. 18.35 skrev Fulko Hew:

> The error _is_ in the ifdef, looking at that code... the ifdef
> polarity does not match
> the polarity in the comments, but the comments _do_ match the
> polarity of the libpcap.

Ubuntu ships with an old libpcap, which tricked me when testing.
My Fedora Core 7 and my OSX has the same problem.

But it seems to be working correctly on win32 with winpcap 4.0.1,
which makes me believe the correct fix would be to use the same
calculations for both winpcap and libpcap.

Any comments?

That would tell me, that wpcap has been fixed, and the (broken) ifdef is no longer
required for wpcap, but I can't prove that.

Then there's the whole problem about the various permutations of bad libraries
with broken ifdef working on some platforms but not others, etc.

I say 'move forwards' and use code as per documentation, and not include
busted code to fix busted libraries... get the library fixed instead, and if thats
not possible, then those people are out-of-luck till _their_ library is/was fixed.