Wireshark-dev: Re: [Wireshark-dev] [Bug 1767] packet-3com-xns.c display filter field problems
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Richard van der Hoff <richardv@xxxxxxxxxxxxx>
Date: Thu, 23 Aug 2007 20:41:12 +0100
Joerg Mayer wrote:

On Thu, Aug 23, 2007 at 05:13:23PM +0000, bugzilla-daemon@xxxxxxxxxxxxx wrote:

I happened to notice that this dissector had 2 duplicate display filter fields.
 That's only because there are only 2 fields!  It will be nearly impossible to
find duplicates in other dissectors with large numbers of fields.  Some
automated method should be instituted if possible.


Hmm, perhaps the tools/checkhf.pl script can be enhanced?
In some cases, having two fields with the same name is deliberate - for instance, in an IAX2 packet, the timestamp can be a field of either 32 bits, 16 bits, or 15 bits, depending on the type of packet. In general you wan these to be different hf_* definitions, but for the user to be able to refer to them with one name.
I'm not sure I'm dead set on this being a feature, but I do think it should be thought through before disabling this. 

Cheers

Richard