Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 22586: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

[Jaap Keuter <jaap.keuter@xxxxxxxxx>]

Hi,

So that is a general objection to the line-style, not so much providing 
additional information. Sorry, but that gets a markdown in my book. 
Sure, the style may be less ideal, but style consistency should take 
precedence.

Thanx,
Jaap

Stig Bjørlykke wrote:
> Den 23. aug. 2007 kl. 00.34 skrev Guy Harris:
>
> > That's adding one more layer, with what amounts to a copy of the value
> > underneath it.  Other than providing the raw offset, what advantages
> > does it offer?  (There, I think, are other dissectors that have
> > bitfields that aren't in a subtree; if the word containing all the
> > bitfields isn't specified as an item of its own in the protocol, I'm
> > not sure it needs to be put into the protocol tree.)
>
> I think it's much more easy to read the leading text and the value if  
> the details of the bitfields does not start the line.  Ofcourse my  
> personal opinion, but mostly I do not care about the bits.