Wireshark-dev: Re: [Wireshark-dev] New Dissector for CMPP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Date: Fri, 20 Jul 2007 16:56:56 -0400


Andy Chu wrote:

Hi dev,

The attachment is a plugin for China Mobile Point to Point (cmpp)
protocol, it's the SMS protocol used in China. I have test it on Mac
OS X and Fedora Core 5.


Sorry for the delay in reviewing your code.  A few comments:
- Would you mind converting this to a regular dissector (in epan/dissectors/) instead of a plugin? I, personally, am not a big fan of plugins. 

- Here:


                        /* CMPP_TERMINATE and CMPP_TERMINATE_RESP don't have msg body */
                        case 0x00000002:
                                break;
                        case 0x80000002:
                                break;
you've got #defines for these numbers, why not use them (it'll make it more readable)? 

- Here: