Wireshark · Wireshark-dev: Re: [Wireshark-dev] dissector for DRM Distribution Interfaces

["Graeme Lunt" <graeme.lunt@xxxxxxxxx>]

Julian,

 

No - I think it just didn't get picked up.

 

Anyway, I've had a look and the dissectors don't compile on Windows - list of errors/warnings at the end.

 

There are specific problems around the use of ULL (use G_GINT64_CONSTANT()).

Other things like initializing variables in their declaration.

 

Could you have a look through doc/README.developer, revise the code accordingly and re-submit?

 

Also, do you have an example capture file you could distribute?

 

Graeme

 

packet-drm-di.c
packet-drm-di.c(163) : error C2220: warning treated as error - no object file generated
packet-drm-di.c(163) : warning C4244: 'initializing' : conversion from 'unsigned __int64 ' to 'unsigned short ', possible loss of data
packet-drm-di.c(164) : error C2059: syntax error : 'bad suffix on number'
packet-drm-di.c(164) : error C2146: syntax error : missing ';' before identifier 'L'
packet-drm-di.c(164) : error C2065: 'L' : undeclared identifier
packet-drm-di.c(165) : warning C4244: '=' : conversion from 'unsigned __int64 ' to 'long ', possible loss of data
packet-drm-rsci.c
packet-drm-rsci.c(95) : error C2220: warning treated as error - no object file generated
packet-drm-rsci.c(95) : warning C4244: 'return' : conversion from 'double ' to 'float ', possible loss of data
packet-drm-rsci.c(105) : warning C4244: 'return' : conversion from 'double ' to 'float ', possible loss of data
packet-drm-rsci.c(194) : error C2065: 'int16_t' : undeclared identifier
packet-drm-rsci.c(194) : error C2059: syntax error : ')'
packet-drm-rsci.c(250) : warning C4244: 'initializing' : conversion from 'double ' to 'float ', possible loss of data
packet-drm-rsci.c(430) : error C2059: syntax error : 'bad suffix on number'
packet-drm-rsci.c(430) : error C2146: syntax error : missing ')' before identifier 'L'
packet-drm-rsci.c(667) : warning C4244: 'initializing' : conversion from 'double ' to 'float ', possible loss of data
packet-drm-packet-mode.c
packet-drm-packet-mode.c(142) : error C2220: warning treated as error - no object file generated
packet-drm-packet-mode.c(142) : warning C4244: 'initializing' : conversion from 'unsigned long ' to 'unsigned short ', possible loss of data

 

 

---

From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Julian Cable
Sent: 15 July 2007 12:12
To: wireshark-dev@xxxxxxxxxxxxx
Subject: Re: [Wireshark-dev] dissector for DRM Distribution Interfaces

Hi,

  I'm re-sending this as it didn't get any response last month. It would be great to get these dissectors into wireshark. Did I do something wrong or is it just a bad time?

cheers

Julian

----- Forwarded Message ----
From: Julian Cable <julian_cable@xxxxxxxxx>
To: wireshark-dev@xxxxxxxxxxxxx
Sent: Tuesday, 12 June, 2007 8:16:44 PM
Subject: dissector for DRM Distribution Interfaces

Hi, I finally finished the dissectors for the Digital Radio Mondiale distribution interfaces. This covers the protocols defined in

ETSI TS 102 820 The Multiplex Distribution Interface (MDI)
and
ETSI TS 102 349 The Receiver Control and Status Interface (RSCI)

I couldn't work out how to use the reassemble functions simultaneously at multiple layers
so I included my own (reassemble2.*). If anyone can work out how to use the normal ones I'd be pleased to know. Mine don't do the "reasembled in" stuff but they are "layer clean" so I can re-use them again in the higher layers of data application decoding (not included in this submission).

The protocols sit on top of the ETSI-DCP protocol I submitted last year.

Patch against SVN attached.

Julian

---

Now you can scan emails quickly with a reading pane. Get the new Yahoo! Mail.

---

Yahoo! Mail is the world's favourite email. Don't settle for less, sign up for your free account today.