Wireshark-dev: [Wireshark-dev] [PATCH] BACnet bacapp fixes for bug 1670
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Steve Karg <skarg@xxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 06 Jul 2007 15:12:49 -0700
Hello Developers,

Attached is a patch that fixes bug 1670 and related issues.

For the BACnet GetEventInformation-ACK request dissector:
1. Corrected BitString decoding for acknowledgedTransitions and eventEnable.

2. Corrected the ability to decode more than one event.

3. Grouped each item of the sequence using subtrees.  Added more informative
text to Priority and Timestamp.

4. Corrected eventState to use BACnetEventState enumeration instead of
BACnetEventStateFilter.

I validated the results with the capture attached to the bug report.  I also
fuzz tested for awhile with my captures with no failures.

Best Regards,

Steve
-- 
http://steve.kargs.net/

Attachment: packet-bacapp.patch.gz
Description: GNU Zip compressed data