Wireshark · Wireshark-dev: Re: [Wireshark-dev] [PATCH]: New packet disscetor for IEEE1588v2 / PTPv2

["Anders Broman" <a.broman@xxxxxxxxx>]

Hi,
I will appliy the ETHERTYPES patch but can you please change the other patch
to not do:
- * Wireshark - Network traffic analyzer
- * By Gerald Combs <gerald@xxxxxxxxxxxxx>
+ * Ethereal - Network traffic analyzer
+ * By Gerald Combs <gerald@xxxxxxxxxxxx>
There is also another instance of "Ethereal" that should be changed.

The names comes out strange on my computer
- * Copyright 2004, Dominic Béchaz <bdo@xxxxxxxx> , ZHW/InES
+ * Copyright 2004, Dominic B�chaz <bdo@xxxxxxxx> , ZHW/InES
  * Copyright 2004, Markus Seehofer <mseehofe@xxxxxxxxxxxxxxxx>
+ * Copyright 2006, Christian Sch�r <scc@xxxxxxxx>
+ * Copyright 2007, Markus Renz <Markus.Renz@xxxxxxxxxxxxx>
Might be changed to.

+    /* Create and set the string for "Info" column */
+	switch(ptp_v2_messageid){
:
Could be changed to something like:
	  if (check_col(pinfo->cinfo, COL_INFO)){
	    col_append_fstr(pinfo->cinfo, COL_INFO, 
	       val_to_str ptp_v2_messageid, ptp_v2_messageid_vals, "Unknown
PTP Message (%u)"));

Regards
Anders

-----Ursprungligt meddelande-----
Från: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] För Seehofer, Markus
Skickat: den 27 juni 2007 11:02
Till: wireshark-dev@xxxxxxxxxxxxx
Ämne: [Wireshark-dev] [PATCH]: New packet disscetor for IEEE1588v2 / PTPv2


Hello,

enclosed you find a new version of the IEEE1588/PTP
dissector. This dissector now includes the coming
version 2 of the standard. It supports both IP/UDP
and pure ethernet frames.

Kind Regards,
 Markus Seehofer

---------------------------------------
Dipl.-Ing. (FH) Markus Seehofer
Development Industrial Ethernet / AEI
Hirschmann Automation and Control GmbH
P.O. Box 1649
72564 Neckartenzlingen, Germany
mailto:Markus.Seehofer@xxxxxxxxxxxxx
http://www.hirschmann-ac.com
--------------------------------------- 

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * 
Hirschmann Automation and Control GmbH, Neckartenzlingen 
Amtsgericht Stuttgart HRB 225927 UST.-IdNr. DE 814 212 604
Geschäftsführer: Reinhard Sitzmann (Vors.) Laurence Burns, 
Rainer Schenkyr, Dr. Georg Schneider
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * *