You are right I missed that in the README.
One thing I noticed was if you ended up with %s (ala fuzztest) in the
buffer when you call proto_tree_add_text it will seg fault because of
the call to g_vsnprintf under the covers can't handle a %s with a NULL
buffer. So I escaped that if it occurs which seems to fix the problem.
Is there a better way to guard against this? See
http://mail.gnome.org/archives/gtk-devel-list/2005-May/msg00031.html
Don Newton
-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Joerg Mayer
Sent: Tuesday, June 12, 2007 12:13 AM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Unistim plugin
On Mon, Jun 11, 2007 at 06:45:25PM -0400, Newton, Don wrote:
> It has been tested on both Linux and Windows XP.
Please perform some fuzz testing. This is likely to crash the code:
None(?) of the value_strings are properly terminated {0, NULL}
Also, please add the standard header to all the source files.
I haven't looked at the code, just skimmed over the beginnings of the
patch.
Ciao
Joerg
--
Joerg Mayer <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev
Attachment:
patch-unistim.gz
Description: patch-unistim.gz
