Wireshark-dev: Re: [Wireshark-dev] AMQP dissector patch
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Martin Sustrik <sustrik@xxxxxxxxxx>
Date: Fri, 01 Jun 2007 07:15:38 +0200
Steve,
The problem is that the code is generated from the protocol specification. If I was to find out which parameters actually need _U_ and which do note, the code generation would get considerably more complex (two passes instead of single one). 

Martin

From: Stephen Fisher <stephentfisher@xxxxxxxxx>
Date: Mon, 21 May 2007 14:02:33 -0700

On Mon, May 21, 2007 at 02:30:59PM +0200, Martin Sustrik wrote:

> Here's the patch for following issues:
>
> - If there are several AMQP frames in single TCP packet, all of them are
> shown in the 'info' column
> - AMQP heartbeat is dissected correctly, it doesn't assert any more
>
> Can you please apply the patch to the SVN?

I have one question before applying the patch.  Both in your patch and
in the existing code, many functions have _U_ for every paramter in
functions, even when those variables are used within the function.  Any
idea why that is?


Steve