Wireshark-dev: Re: [Wireshark-dev] FW: DISSECTOR_ASSERT_NOT_REACHED in WLCCP decode...
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Wed, 30 May 2007 22:18:13 +0200
On Wed, May 30, 2007 at 01:15:35PM -0700, Stephen Fisher wrote:
> > So I'm looking at the value strings, and I'm wondering why we should 
> > terminate them with {0, NULL} and what happens if one of the value 
> > pairs needs to be {0, "a real string"} ?
> 
> You can still use 0, "a real string" as one of the entries.  You just 
> need to have 0, NULL as the final entry.  If you don't, the code will 
> keep reading past the end and run into random memory space looking for 
> that 0, NULL entry.

And one of those overruns might actually cause the crash you were
talking about.

 Cia
 o  Joerg

-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.