Wireshark-dev: Re: [Wireshark-dev] [PATCH] Improved support for MIPv4
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: "Ville Nuorvala" <ville.nuorvala@xxxxxxxxx>
Date: Fri, 18 May 2007 13:59:46 +0300
On 5/16/07, Jaap Keuter <jaap.keuter@xxxxxxxxx> wrote:

Hi,

Some additional notes:

+  {REGISTRATION_REVOCATION, "Registration Revocation"},
+  {REGISTRATION_REVOCATION, "Registration Revocation Acknowledgement"},

The second one misses _ACKNOWLEDGEMENT in the symbol


Oops, how did I miss that one?


   {0, NULL},
 };

Don't put a comma after the last initializer. It's just poor style.


Thanks, I'll fix these.

Regards,
Ville