Wireshark · Wireshark-dev: [Wireshark-dev] OpCua faulty checkin and breaks the build

[Jaap Keuter <jaap.keuter@xxxxxxxxx>]

Hi,

Multiple things are wrong with the recently added OpCua plugin:

- There are no properties on the directory or the files,
- The headers are missing from the Makefile.common, breaking the dist,
- Not all DISSECTOR_SRC are dissector main entry point. The rest should be
in the DISSECTOR_SUPPORT_SRC symbol,
- Makefile.nmake should be the generalized kind,
- Don't check in the plugin.c, it's generated,
- plugin.rc.in is missing, as is moduleinfo.nmake,
- neither if these are in the dist,
- non standard headers on the source files.

It looks like a rushed check in, something we should try to avoid.

Thanks,
Jaap