Wireshark · Wireshark-dev: Re: [Wireshark-dev] [PATCH] UMTS Frame Protocol: more K12/K15 support, Spare Extension fields

["Martin Mathieson" <martin.r.mathieson@xxxxxxxxxxxxxx>]

On 5/3/07, Kriang Lerdsuwanakij <lerdsuwa@xxxxxxxxxxxxxxxxxxxxx> wrote:

Hello

This patch adds the handling of Spare Extension bytes
to UMTS Frame Protocol.  It also handles the case when
the presence of CRC in dedicated channels is not known
(i.e. when FP from a K12/K15 log is dissected).

The new functionality is placed in the new function
"dissect_spare_extension_and_crc".  The "dch_crc_present"
field inside "struct fp_info" (file packet-umts_fp.h)
is also extended to handle the case of unknown CRC presence.

Much of other changes is to update "offset" variable and
return it so that the location of Spare Extension and CRC
is available.

This sounds good to me.  When I get back on Tuesday I'll test my captures against the changes and check it in (if no-one else has).

The patch also include a small tweak to handle Frame
Protocol information saved from K15.  Some fields appear
8 bytes later compared to K12.  The changes are in the file
packet-k12.c.

A test .rf5 file demonstrating Spare Extension is also
provided in the attachment.  It's modified using hexedit to
add the Spare Extension, then open and resave again from K15
reader. K15 produces the same result as this proposed patch
to wireshark.

One of the reasons I hadn't added Spare Extension before if that I've never seen it appear in frames in practice, and it sounds as though you had to fake it in order to test your patch?  It'll be good to have it for completeness though!  Do you happen to know of any equipment that does write out Spare Extension bytes?

Best regards,
Martin
 

Best regards

Kriang Lerdsuwanakij


_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev