Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 21637: /trunk/gtk/ /trunk/gtk/: foll
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Wed, 2 May 2007 13:08:27 +0200
On Wed, May 02, 2007 at 08:50:22AM +0000, sahlberg@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=21637
> 
> Log:
>  store the result of fread in a variable  to make -Werror happy
> 
> Directory: /trunk/gtk/
>   Changes    Path            Action
>   +2 -1      follow_dlg.c    Modified

That's the type of bugfix that doesn't make much sense. Just a dummy
read to squelch the warning without fixing the reason that the waring
was generated in the first place:
To state this differently: What happens, if the read doesn't return the
necessary amount of data?

 Ciao
    Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.