Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 21635:/trunk//trunk/epan/dissectors/: packet-gsm_map.cpa

["Kukosa, Tomas" <tomas.kukosa@xxxxxxxxxxx>]

OK I will try to keep it in my mind.
I prefer another approach when each .h file includes what it needs and other files need not to know its dependency.

Regards,
  Tomas

Mailcode: NdD2sKHg
-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Anders Broman
Sent: Wednesday, May 02, 2007 8:09 AM
To: 'Developer support list for Wireshark'
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 21635:/trunk//trunk/epan/dissectors/: packet-gsm_map.cpacket-gtp.cpacket-h221_nonstd.c packet-h225.cpacket-h225.hpacket-h235.c packet-h245.c packet-h245.hpacket-h450.cpacket-h450.h ...



-----Ursprungligt meddelande-----
Från: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] För Kukosa, Tomas
Skickat: den 2 maj 2007 07:49
Till: wireshark-dev@xxxxxxxxxxxxx
Ämne: Re: [Wireshark-dev] [Wireshark-commits] rev 21635:
/trunk//trunk/epan/dissectors/: packet-gsm_map.c
packet-gtp.cpacket-h221_nonstd.c packet-h225.c packet-h225.hpacket-h235.c
packet-h245.c packet-h245.h packet-h450.cpacket-h450.h ...


>Is not it enough only to include it into packet-per.h and packet-ber.h? 
>Using asn1.h outside them does not make sense.
>
>Tomas
I thought we didn't like to include .h files in other .h files.
I'm also undecided whether void asn1_ctx_init() should be in asn1.c or not.
Regrads
Anders

-----Original Message-----
From: wireshark-commits-bounces@xxxxxxxxxxxxx
[mailto:wireshark-commits-bounces@xxxxxxxxxxxxx] On Behalf Of
etxrab@xxxxxxxxxxxxx
Sent: Wednesday, May 02, 2007 12:05 AM
To: wireshark-commits@xxxxxxxxxxxxx
Subject: [Wireshark-commits] rev 21635: /trunk/ /trunk/epan/dissectors/:
packet-gsm_map.c packet-gtp.c packet-h221_nonstd.c packet-h225.c
packet-h225.h packet-h235.c packet-h245.c packet-h245.h packet-h450.c
packet-h450.h ...

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=21635

User: etxrab
Date: 2007/05/01 10:05 PM

Log:
 Split out common asn1 stuff to asn1.h and include that where needed.

Directory: /trunk/epan/dissectors/
  Changes    Path                         Action
  +6 -5      packet-gsm_map.c             Modified
  +1 -0      packet-gtp.c                 Modified
  +1 -0      packet-h221_nonstd.c         Modified
  +7 -6      packet-h225.c                Modified
  +3 -2      packet-h225.h                Modified
  +6 -5      packet-h235.c                Modified
  +6 -5      packet-h245.c                Modified
  +1 -1      packet-h245.h                Modified
  +7 -6      packet-h450.c                Modified
  +1 -1      packet-h450.h                Modified
  +8 -7      packet-ldap.c                Modified


(50 files not shown)
_______________________________________________
Wireshark-commits mailing list
Wireshark-commits@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-commits
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev

_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev