Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 21556: /trunk/epan/ /trunk/epan/: proto.c proto.h - all

["Anders Broman" <a.broman@xxxxxxxxx>]

Hi,
I have no problem with backing out my changes but a
Proto_... function should not be local to iuup in my opinion.
Perhaps it should be renamed iuup_proto_.. instead until
We have "the real thing" in proto.c

What do others think?
Regards
Anders

-----Ursprungligt meddelande-----
Från: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] För Ulf Lamping
Skickat: den 24 april 2007 22:12
Till: wireshark-dev@xxxxxxxxxxxxx
Ämne: Re: [Wireshark-dev] [Wireshark-commits] rev 21556: /trunk/epan/
/trunk/epan/: proto.c proto.h - all buildbots red now :-(

etxrab@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=21556
>
> User: etxrab
> Date: 2007/04/24 07:24 PM
>
> Log:
>  Add a new proto function proto_tree_add_bits() which adds bits to the
tree
>  starting at the bit offset given for the number of bits indicated which
wll also return
>  the value of the bits.
>  Experimental and for review, documentation to be updated.
>
>   
All buildbots red now for the same reason:

packet-iuup.c:415: error: conflicting types for `proto_tree_add_bits'
../../epan/proto.h:1587: error: previous declaration of
`proto_tree_add_bits'


Regards, ULFL
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev